Here's my feedback:
1. It seems that the system property "awt.useSystemAAFontSettings" was introduced at java 1.6 (See http://docs.oracle.com/javase/6/docs/te ... ml#aaFonts
). muCommander still supports java 1.5 that refered to the system property "swing.aatext" instead - we should distinguish this case also.
2. I read at http://mindprod.com/jgloss/antialiasing.html
that there are more values other than "lcd" such as "gasp". I think we should let the user choose between those options if we can't determine what is the best option for him.
3. I think a better way would be to add two more attributes for MuConfiguration (which was replaced yesterday by MuPreferences class by the way):
FONT_ANTIALIASING_ON = ...
FONT_ANTIALIASING_OFF = "off"
and then DEFAULT_FONT_ANTIALIASING will be changed to DEFAULT_FONT_ANTIALIASING = FONT_ANTIALIASING_ON and
String aa = isSelected() ? MuConfiguration.DEFAULT_FONT_ANTIALIASING : "off";
will be changed to
String aa = isSelected() ? MuConfiguration.DEFAULT_FONT_ANTIALIASING : MuConfiguration.FONT_ANTIALIASING_OFF;
4. Most of the properties under the preferences dialog are changed when choosing "apply" or "ok" options. that's not the case with the anti-aliasing checkbox - so we may want to add a "restart required to apply the change" next to it, or trying to refresh the mainframe with the updated configuration if it's possible.